Remove '.com' from gogo repository directory structure to avoid python proto module issues#2174
Closed
ddelnano wants to merge 2 commits intopixie-io:mainfrom
Closed
Conversation
… issues Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
ddelnano
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Remove '.com' from gogo repository directory structure to avoid python proto module issues
This prerequisite work unblocks upgrading the Python pxapi's dependencies. pxapi currently uses a deprecated pip package (
gogo-python) that doesn't support proto v3, which prevents upgrading its protobuf dependency and expanding its python version support beyond python 3.11.This change prepares for the removal of
gogo-pythonby ensuring the gogo bazel repositories available in our repo (our internal one andrules_go's) generate valid python code. The current repository naming (github.com/gogo/...) generates python modules that havegithub.comin its name. This is invalid since.'s are used for specifying module names. The fix is to rename the gogo repositories to usegithub/cominstead ofgithub.com.Relevant Issues: #2140
Type of change: /kind bugfix
Test Plan: Existing tests should pass